curcur commented on pull request #13581: URL: https://github.com/apache/flink/pull/13581#issuecomment-750800553
Just one more thing: I think the description could be a bit more informative: something like this: """ Currently, the length of some header fields in NettyMessage is hardcoded: InputChannelID, ExecutionAttemptID, e.t.c. So if we make some changes for such field, then we are not ware that it also needs to change the respective length for related netty messages component. This PR explicitly get the ByteBuf length of all classes which is written to NettyMessage to avoid such problems. """ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
