curcur commented on pull request #13581:
URL: https://github.com/apache/flink/pull/13581#issuecomment-750000919


   @KarmaGYZ , thanks for the PR.
   
   I think the PR is quite safe to go, and I left a few minor comments.
   
   Besides that, I have a few comments on the filed PR itself.
   
   1. Maybe add a bit more detail the motivation of this change in the section 
of "What is the purpose of the change".
   2. Would you please add a test for NettyMessage.java as well? No matter 
what, that's the main purpose of the change.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to