xiaoHoly commented on a change in pull request #14387:
URL: https://github.com/apache/flink/pull/14387#discussion_r547069065
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/JdbcBatchingOutputFormat.java
##########
@@ -179,11 +178,9 @@ public synchronized void flush() throws IOException {
throw new IOException(e);
}
try {
- if
(!connection.isValid(CONNECTION_CHECK_TIMEOUT_SECONDS)) {
Review comment:
I think we should set this configuration in only one place ,this is the
reason I remove the code in JdbcBatchingOutputFormat.java.
@wangxlong thanks for your work with your commit
wangxlong@4f7d5aa,according to your code i will migrate this configuration to
JdbcExecutionOptions .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
