wuchong commented on a change in pull request #14387:
URL: https://github.com/apache/flink/pull/14387#discussion_r547057104
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/JdbcBatchingOutputFormat.java
##########
@@ -179,11 +178,9 @@ public synchronized void flush() throws IOException {
throw new IOException(e);
}
try {
- if
(!connection.isValid(CONNECTION_CHECK_TIMEOUT_SECONDS)) {
Review comment:
I would like to avoid to put this configuration in multiple places (we
may also need this in reader in the future), otherwise, it is easy to have
inconsistent configuration.
Another idea is puting this in `JdbcConnectionOptions` as it belongs to
connection scope.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
