Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1790#discussion_r56173641
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -234,7 +235,9 @@ public WebRuntimeMonitor(
.GET("/jobs/:jobid/checkpoints", handler(new
JobCheckpointsHandler(currentGraphs)))
.GET("/taskmanagers", handler(new
TaskManagersHandler(DEFAULT_REQUEST_TIMEOUT)))
- .GET("/taskmanagers/:" +
TaskManagersHandler.TASK_MANAGER_ID_KEY, handler(new
TaskManagersHandler(DEFAULT_REQUEST_TIMEOUT)))
+ .GET("/taskmanagers/:" +
TaskManagersHandler.TASK_MANAGER_ID_KEY + "/metrics", handler(new
TaskManagersHandler(DEFAULT_REQUEST_TIMEOUT)))
+ .GET("/taskmanagers/:" +
TaskManagersHandler.TASK_MANAGER_ID_KEY + "/log", new
TaskManagerLogHandler(retriever, actorSystem.dispatcher(),
jobManagerAddressPromise.future(), timeout, true))
--- End diff --
I think we shouldn't use the dispatcher of the `ActorSystem` as the
`ExecutorService` here. The `ActorSystem` is usually the `ActorSystem` of the
JM and we shouldn't put load on its `ThreadPool`. I would rather use a
dedicated `ThreadPool` for the execution of the futures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
