aljoscha commented on a change in pull request #14096:
URL: https://github.com/apache/flink/pull/14096#discussion_r525047494



##########
File path: 
flink-connectors/flink-connector-elasticsearch6/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSinkITCase.java
##########
@@ -61,7 +65,20 @@
 public class Elasticsearch6DynamicSinkITCase {
 
        @ClassRule
-       public static ElasticsearchResource elasticsearchResource = new 
ElasticsearchResource("es-6-dynamic-sink-tests");
+       public static ElasticsearchContainer elasticsearchContainer =

Review comment:
       It's the Google Java Style, which is a subset (or superset depending on 
where you're coming from 😅) of our (very relaxed) coding style so I prefer that 
one.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to