AHeise commented on a change in pull request #14096:
URL: https://github.com/apache/flink/pull/14096#discussion_r525045036
##########
File path:
flink-connectors/flink-connector-elasticsearch5/src/test/java/org/apache/flink/streaming/connectors/elasticsearch5/ElasticsearchSinkITCase.java
##########
@@ -37,6 +40,21 @@
*/
public class ElasticsearchSinkITCase extends
ElasticsearchSinkTestBase<TransportClient, InetSocketAddress> {
+ protected static final String CLUSTER_NAME = "test-cluster";
+
+ @ClassRule
+ public static ElasticsearchResource elasticsearchResource = new
ElasticsearchResource(CLUSTER_NAME);
Review comment:
Can't we use it with ES5? (no docker image?)
##########
File path:
flink-connectors/flink-connector-elasticsearch6/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/table/Elasticsearch6DynamicSinkITCase.java
##########
@@ -61,7 +65,20 @@
public class Elasticsearch6DynamicSinkITCase {
@ClassRule
- public static ElasticsearchResource elasticsearchResource = new
ElasticsearchResource("es-6-dynamic-sink-tests");
+ public static ElasticsearchContainer elasticsearchContainer =
Review comment:
nit: the linebreaks look weird (ditto on other container fields).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
