rkhachatryan commented on pull request #14051: URL: https://github.com/apache/flink/pull/14051#issuecomment-728195493
I mentioned it in JIRA (and now pulled to PR description): > This change leaves `statePersister` mutable in channels that will be converted after requesting partitions. There is no race condition here because requesting partitions and conversion is done by the same (task) thread. So it does solve the threading problem. Another problem it solves is that `UnknownInputChannels` weren't aware of `statePersister` and weren't passing it to "known" channels upon conversion. I didn't enforce setting `statePersister` on `UnknownInputChannels` though because it's not relevant for all the cases (e.g. batch). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
