AHeise commented on pull request #14051: URL: https://github.com/apache/flink/pull/14051#issuecomment-728028943
In general, I would have liked to make the statePersister immutable from the get-go. However, you also managed to make it immutable only for the `Local/RemoteInputChannel` - all other channels, DI still happens through setter. I'm not sure what the value of this intermediate solution is. Now, for some channels DI happens through ctor and for some through the setter. Certainly the threading model is much more unfortunate with a setter-based DI. But it's not solved by this PR as for all setter-based input channels, the issue still prevails (What happens if I created `UnknownChannel` in thread1, set channel persister in thread2, and then convert to local channel in thread1?) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
