SteNicholas commented on a change in pull request #13828: URL: https://github.com/apache/flink/pull/13828#discussion_r513842239
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java ########## @@ -254,4 +269,10 @@ private void registerReader() { ListState<SplitT> getReaderState() { return readerState; } + + // Not really meant to be here, this is an example. + // TODO: Should we use RuntimeExecutionMode here? I don't like that that one has AUTOMATIC. + public enum RuntimeMode { + BATCH, STREAMING Review comment: @aljoscha @dawidwys @kl0u I have confusion about which choice should follow. As @aljoscha mentioned that he prefers to use more enums than boolean. And @dawidwys @kl0u prefers to use a boolean. I would like to follow your standard later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org