kl0u commented on a change in pull request #13828:
URL: https://github.com/apache/flink/pull/13828#discussion_r513675900



##########
File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/source/SourceOperatorEventTimeTest.java
##########
@@ -161,6 +199,7 @@ public void testPerSplitOutputEventWatermarks() throws 
Exception {
        @SuppressWarnings("FinalPrivateMethod")
        @SafeVarargs
        private final List<Object> testSequenceOfEvents(
+                       SourceOperator.RuntimeMode runtimeMode,

Review comment:
       Here we use `final` for some args and nothing for others. So feel free 
to uniformize them the way you feel more comfortable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to