azagrebin commented on a change in pull request #13547:
URL: https://github.com/apache/flink/pull/13547#discussion_r509100903
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/util/MetricUtils.java
##########
@@ -131,11 +147,47 @@ public static void instantiateStatusMetrics(
instantiateClassLoaderMetrics(jvm.addGroup("ClassLoader"));
instantiateGarbageCollectorMetrics(jvm.addGroup("GarbageCollector"));
- instantiateMemoryMetrics(jvm.addGroup("Memory"));
+ instantiateMemoryMetrics(jvm.addGroup(METRIC_GROUP_MEMORY));
instantiateThreadMetrics(jvm.addGroup("Threads"));
instantiateCPUMetrics(jvm.addGroup("CPU"));
}
+ public static void instantiateFlinkMemoryMetricGroup(
+ MetricGroup parentMetricGroup,
+ TaskManagerServices taskManagerServices) {
Review comment:
nit: I think `TaskManagerServices` is too heavy to pass for managed
memory metrics.
I would pass `TaskSlotTable` and managed memory size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
