azagrebin commented on a change in pull request #13547:
URL: https://github.com/apache/flink/pull/13547#discussion_r508297589
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java
##########
@@ -199,10 +208,11 @@ default int freeSlot(AllocationID allocationId) throws
SlotNotFoundException {
/**
* Return an iterator of allocated slots for the given job id.
*
- * @param jobId for which to return the allocated slots
+ * @param jobId for which to return the allocated slots. If {@code
null} is passed,
+ * all allocated slots held by this {@code TaskSlotTable} are returned.
* @return Iterator of allocated slots.
*/
- Iterator<TaskSlot<T>> getAllocatedSlots(JobID jobId);
+ Iterator<TaskSlot<T>> getAllocatedSlots(@Nullable JobID jobId);
Review comment:
sorry for confusion, by "previous version", I mean where the
"jobId"-methods did not have additional semantics for `jobId == null` and we
had a dedicated method for that.
There I wanted to suggest having separate constructors for
`TaskSlotIterator` with and without `jobId`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
