libenchao commented on a change in pull request #13519:
URL: https://github.com/apache/flink/pull/13519#discussion_r503014325
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/over/AbstractRowTimeUnboundedPrecedingOver.java
##########
@@ -68,6 +70,17 @@
protected transient AggsHandleFunction function;
+ //
------------------------------------------------------------------------
+ // Metrics
+ //
------------------------------------------------------------------------
+ protected static final String LATE_ELEMENTS_DROPPED_METRIC_NAME =
"numLateRecordsDropped";
+ private transient Counter numLateRecordsDropped;
+
+ @VisibleForTesting
+ public Counter getCounter() {
Review comment:
we could not access it if it's `private`, `protected` methods can be
accessed in tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
