zhuxiaoshang commented on a change in pull request #13519:
URL: https://github.com/apache/flink/pull/13519#discussion_r502937004
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/over/RowTimeRangeBoundedPrecedingFunction.java
##########
@@ -86,12 +90,25 @@
private transient AggsHandleFunction function;
+ //
------------------------------------------------------------------------
+ // Metrics
+ //
------------------------------------------------------------------------
+ protected static final String LATE_ELEMENTS_DROPPED_METRIC_NAME =
"numLateRecordsDropped";
+ protected static final String LATE_ELEMENTS_DROPPED_RATE_METRIC_NAME =
"lateRecordsDroppedRate";
+ private transient Counter numLateRecordsDropped;
+ private transient Meter lateRecordsDroppedRate;
+
+ @VisibleForTesting
+ public Counter getCounter() {
+ return numLateRecordsDropped;
+ }
+
public RowTimeRangeBoundedPrecedingFunction(
- GeneratedAggsHandleFunction genAggsHandler,
- LogicalType[] accTypes,
- LogicalType[] inputFieldTypes,
- long precedingOffset,
- int rowTimeIdx) {
+ GeneratedAggsHandleFunction genAggsHandler,
+ LogicalType[] accTypes,
+ LogicalType[] inputFieldTypes,
+ long precedingOffset,
+ int rowTimeIdx) {
Review comment:
Sorry for my IDEA code format changed this,i'll revert it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
