pnowojski commented on a change in pull request #13180:
URL: https://github.com/apache/flink/pull/13180#discussion_r472352387



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnable.java
##########
@@ -129,12 +129,10 @@ public void run() {
                                        checkpointMetaData.getCheckpointId());
                        }
                } catch (Exception e) {
-                       if (LOG.isDebugEnabled()) {
-                               LOG.debug("{} - asynchronous part of checkpoint 
{} could not be completed.",
-                                       taskName,
-                                       checkpointMetaData.getCheckpointId(),
-                                       e);
-                       }
+                       LOG.info("{} - asynchronous part of checkpoint {} could 
not be completed.",

Review comment:
       Won't this flood log with exceptions in some cases?
   
   There was some [relevant 
discussion](https://github.com/apache/flink/pull/9873/files/d62e6daf023f440f25fa2ea5a55081e513a5fcd0#diff-9437cb4899bb946f234c272be6724770)
 about this when it was being introduced.
   
   CC @klion26 ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to