rkhachatryan commented on a change in pull request #13180:
URL: https://github.com/apache/flink/pull/13180#discussion_r472214667
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -387,6 +387,7 @@ function check_logs_for_exceptions {
| grep -v "WARN
org.apache.flink.shaded.akka.org.jboss.netty.channel.DefaultChannelPipeline" \
| grep -v 'INFO.*AWSErrorCode' \
| grep -v "RejectedExecutionException" \
+ | grep -v "CancellationException" \
Review comment:
My change causes `CancellationException` to be logged at `INFO` level as
any other exception (which I think is fine).
In general, I think `CancellationException` in logs shouldn't fail the tests
(unless it's cause by some other exception, which will be detected by script).
So I made it a separate commit.
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -387,6 +387,7 @@ function check_logs_for_exceptions {
| grep -v "WARN
org.apache.flink.shaded.akka.org.jboss.netty.channel.DefaultChannelPipeline" \
| grep -v 'INFO.*AWSErrorCode' \
| grep -v "RejectedExecutionException" \
+ | grep -v "CancellationException" \
Review comment:
My change causes `CancellationException` to be logged at `INFO` level as
any other exception (which I think is fine).
In general, I think `CancellationException` in logs shouldn't fail the tests
(unless it's caused by some other exception, which will be detected by script).
So I made it a separate commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
