tillrohrmann commented on a change in pull request #13111:
URL: https://github.com/apache/flink/pull/13111#discussion_r469917288



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerRunnerImpl.java
##########
@@ -137,7 +138,12 @@ public JobManagerRunnerImpl(
                this.leaderGatewayFuture = new CompletableFuture<>();
 
                // now start the JobManager
-               this.jobMasterService = 
jobMasterFactory.createJobMasterService(jobGraph, this, userCodeLoader);
+               try {
+                       this.jobMasterService = 
jobMasterFactory.createJobMasterService(jobGraph, this, userCodeLoader);
+               } catch (Throwable t) {
+                       
ClusterEntryPointExceptionUtils.tryEnrichClusterEntryPointError(t);
+                       throw t;
+               }

Review comment:
       `Dispatcher.runRecoveredJob` will call `handleRecoveredJobStartError` if 
there is an error. This method will call the `ClusterEntrypoint's` fatal error 
handler which should already do the enrichment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to