sjwiesman commented on a change in pull request #129:
URL: https://github.com/apache/flink-statefun/pull/129#discussion_r465821324
##########
File path:
statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/feedback/FeedbackUnionOperator.java
##########
@@ -61,14 +62,16 @@
SerializableFunction<T, ?> keySelector,
long totalMemoryUsedForFeedbackCheckpointing,
TypeSerializer<T> elementSerializer,
- MailboxExecutor mailboxExecutor) {
+ MailboxExecutor mailboxExecutor,
+ ProcessingTimeService processingTimeService) {
this.feedbackKey = Objects.requireNonNull(feedbackKey);
this.isBarrierMessage = Objects.requireNonNull(isBarrierMessage);
this.keySelector = Objects.requireNonNull(keySelector);
this.totalMemoryUsedForFeedbackCheckpointing =
totalMemoryUsedForFeedbackCheckpointing;
this.elementSerializer = Objects.requireNonNull(elementSerializer);
this.mailboxExecutor = Objects.requireNonNull(mailboxExecutor);
this.chainingStrategy = ChainingStrategy.ALWAYS;
+ this.processingTimeService = processingTimeService;
Review comment:
I take it back, this change is necessary.
```
java.lang.Exception: Exception while creating StreamOperatorStateContext.
at
org.apache.flink.streaming.api.operators.StreamTaskStateInitializerImpl.streamOperatorStateContext(StreamTaskStateInitializerImpl.java:204)
at
org.apache.flink.streaming.api.operators.AbstractStreamOperator.initializeState(AbstractStreamOperator.java:247)
at
org.apache.flink.streaming.runtime.tasks.OperatorChain.initializeStateAndOpenOperators(OperatorChain.java:290)
at
org.apache.flink.streaming.runtime.tasks.StreamTask.lambda$beforeInvoke$0(StreamTask.java:473)
at
org.apache.flink.streaming.runtime.tasks.StreamTaskActionExecutor$1.runThrowing(StreamTaskActionExecutor.java:47)
at
org.apache.flink.streaming.runtime.tasks.StreamTask.beforeInvoke(StreamTask.java:469)
at
org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:522)
at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:721)
at org.apache.flink.runtime.taskmanager.Task.run(Task.java:546)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NullPointerException
at
org.apache.flink.util.Preconditions.checkNotNull(Preconditions.java:58)
at
org.apache.flink.streaming.api.operators.InternalTimeServiceManager.<init>(InternalTimeServiceManager.java:88)
at
org.apache.flink.streaming.api.operators.StreamTaskStateInitializerImpl.internalTimeServiceManager(StreamTaskStateInitializerImpl.java:225)
at
org.apache.flink.streaming.api.operators.StreamTaskStateInitializerImpl.streamOperatorStateContext(StreamTaskStateInitializerImpl.java:167)
... 9 more
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
