sjwiesman commented on a change in pull request #129:
URL: https://github.com/apache/flink-statefun/pull/129#discussion_r465808375
##########
File path:
statefun-flink/statefun-flink-core/src/main/java/org/apache/flink/statefun/flink/core/feedback/FeedbackUnionOperator.java
##########
@@ -61,14 +62,16 @@
SerializableFunction<T, ?> keySelector,
long totalMemoryUsedForFeedbackCheckpointing,
TypeSerializer<T> elementSerializer,
- MailboxExecutor mailboxExecutor) {
+ MailboxExecutor mailboxExecutor,
+ ProcessingTimeService processingTimeService) {
this.feedbackKey = Objects.requireNonNull(feedbackKey);
this.isBarrierMessage = Objects.requireNonNull(isBarrierMessage);
this.keySelector = Objects.requireNonNull(keySelector);
this.totalMemoryUsedForFeedbackCheckpointing =
totalMemoryUsedForFeedbackCheckpointing;
this.elementSerializer = Objects.requireNonNull(elementSerializer);
this.mailboxExecutor = Objects.requireNonNull(mailboxExecutor);
this.chainingStrategy = ChainingStrategy.ALWAYS;
+ this.processingTimeService = processingTimeService;
Review comment:
The processing time service is no longer set by default. We get a
NullPointerException without this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
