godfreyhe commented on a change in pull request #12866:
URL: https://github.com/apache/flink/pull/12866#discussion_r456242471
##########
File path:
flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java
##########
@@ -89,8 +89,11 @@
import static org.apache.flink.util.Preconditions.checkArgument;
/**
- * Test implementation of {@link DynamicTableSourceFactory} that creates
- * a source that produces a sequence of values.
+ * Test implementation of {@link DynamicTableSourceFactory} that creates a
source that produces a sequence of values.
+ * And this source {@link TestValuesTableSource} supports FilterPushDown. And
it has some limitations.
Review comment:
And {@link TestValuesTableSource} can push down filter into table
source. A predicate can be pushed down only if it satisfies the following
conditions:
1. field name is in `filterable-fields` which is defined in `with` properties
2. the field type is comparable
3. UDF is `UPPER` or `LOWER`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
