godfreyhe commented on a change in pull request #12866:
URL: https://github.com/apache/flink/pull/12866#discussion_r456228726
##########
File path:
flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java
##########
@@ -565,14 +562,12 @@ private boolean binaryFilterApplies(CallExpression
binExpr, Row row) {
}
}
- private boolean isComparable(Class<?> clazz) {
- // validate that literal is comparable
+ private void validateTypeComparable(Class<?> clazz) {
Review comment:
I think this method should be
```
private boolean isComparable(Class<?> clazz) {
return Comparable.class.isAssignableFrom(clazz);
}
```
we do not need throw exception if a class is
non-comparable.`TestValuesTableFactory` just does not support non-comparable
type. just like the case that `TestValuesTableFactory` just supports `UPPER`
and `LOWER` UDF.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
