[
https://issues.apache.org/jira/browse/FLINK-18449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151229#comment-17151229
]
Benchao Li edited comment on FLINK-18449 at 7/4/20, 8:12 AM:
-------------------------------------------------------------
I agree with [~jark]'s proposal here, and the reason is:
1. For topic and topic regex
This can be more friendly for single topic users, which I assume is the most of
cases.
2. For topic and partition discovery
'topic-partition-discovery.interval' is good enough, it's explicit and easy to
understand that it controls discovery for both topic and partition.
was (Author: libenchao):
I agree with [~jark]'s proposal here, and the reason is:
# For topic and topic regex
This can be more friendly for single topic users, which I assume is the most of
cases.
# For topic and partition discovery
'topic-partition-discovery.interval' is good enough, it's explicit and easy to
understand that it controls discovery for both topic and partition.
> Make topic discovery and partition discovery configurable for
> FlinkKafkaConsumer in Table API
> ---------------------------------------------------------------------------------------------
>
> Key: FLINK-18449
> URL: https://issues.apache.org/jira/browse/FLINK-18449
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / Kafka, Table SQL / API
> Affects Versions: 1.11.0
> Reporter: Shengkai Fang
> Assignee: Shengkai Fang
> Priority: Major
> Fix For: 1.12.0
>
>
> In streaming api, we can use regex to find topic and enable partiton
> discovery by setting non-negative value for
> `{{flink.partition-discovery.interval-millis}}`. However, it's not work in
> table api. I think we can add options such as 'topic-regex' and
> '{{partition-discovery.interval-millis}}' in WITH block for users.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
