[ 
https://issues.apache.org/jira/browse/FLINK-18449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151151#comment-17151151
 ] 

Jark Wu edited comment on FLINK-18449 at 7/4/20, 3:31 AM:
----------------------------------------------------------

I prefer the following options based on [~Echo Lee]

{code:java}
'topic' = 'topic'                                // for single topic
'topic' = 'topic-1, topic-2,..., topic-n',       // for list topic
'topic-pattern' = 'topic*'                       // for use of regex,  "topic" 
and "topic-pattern" can't coexist
'topic-partition-discovery.interval' = '5s'  // for both topic discovery
// or 'partition-discovery.interval' ?
{code}


What's your opinion [~libenchao]?


was (Author: jark):
I prefer the following options based on [~Echo Lee]

{code:java}
'topic' = 'topic'                                // for single topic
'topic' = 'topic-1, topic-2,..., topic-n',       // for list topic
'topic-pattern' = 'topic*'                       // for use of regex,  "topic" 
and "topic-pattern" can't coexist
'topic-partition-discovery.interval' = '5s'  // for both topic discovery
// or 'partition-discovery.interval'
{code}


What's your opinion [~libenchao]?

> Make topic discovery and partition discovery configurable for 
> FlinkKafkaConsumer in Table API
> ---------------------------------------------------------------------------------------------
>
>                 Key: FLINK-18449
>                 URL: https://issues.apache.org/jira/browse/FLINK-18449
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / Kafka, Table SQL / API
>    Affects Versions: 1.11.0
>            Reporter: Shengkai Fang
>            Assignee: Shengkai Fang
>            Priority: Major
>             Fix For: 1.12.0
>
>
> In streaming api, we can use regex to find topic and enable partiton 
> discovery by setting non-negative value for 
> `{{flink.partition-discovery.interval-millis}}`. However, it's not work in 
> table api. I think we can add options such as 'topic-regex' and 
> '{{partition-discovery.interval-millis}}' in WITH block for users.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to