AHeise commented on a change in pull request #11868:
URL: https://github.com/apache/flink/pull/11868#discussion_r442863664
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -958,10 +960,10 @@ private void configureCheckpointing() {
.setMinPauseBetweenCheckpoints(cfg.getMinPauseBetweenCheckpoints())
.setMaxConcurrentCheckpoints(cfg.getMaxConcurrentCheckpoints())
.setCheckpointRetentionPolicy(retentionAfterTermination)
- .setExactlyOnce(getCheckpointingMode(cfg) ==
CheckpointingMode.EXACTLY_ONCE)
+ .setExactlyOnce(exactlyOnce)
.setPreferCheckpointForRecovery(cfg.isPreferCheckpointForRecovery())
.setTolerableCheckpointFailureNumber(cfg.getTolerableCheckpointFailureNumber())
-
.setUnalignedCheckpointsEnabled(cfg.isUnalignedCheckpointsEnabled())
+ .setUnalignedCheckpointsEnabled(exactlyOnce &&
cfg.isUnalignedCheckpointsEnabled())
Review comment:
Also possible way, it's pretty much ignoring UC when at least once is
set. See also above for a deeper discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
