AHeise commented on a change in pull request #11868:
URL: https://github.com/apache/flink/pull/11868#discussion_r442862960
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -500,8 +500,9 @@ private void setVertexConfig(Integer vertexID, StreamConfig
config,
config.setStateBackend(streamGraph.getStateBackend());
config.setCheckpointingEnabled(checkpointCfg.isCheckpointingEnabled());
-
config.setUnalignedCheckpointsEnabled(checkpointCfg.isUnalignedCheckpointsEnabled());
config.setCheckpointMode(getCheckpointingMode(checkpointCfg));
+
config.setUnalignedCheckpointsEnabled(config.getCheckpointMode() ==
CheckpointingMode.EXACTLY_ONCE &&
Review comment:
So far, we have assumed that the user only sets UC when checkpoint mode
is exactly once. In this PR, we ignoring checkpoint mode and set it for all.
The question is where to address that:
- We could fail on that combination. Then we would need to disable UC for
every at least once test. Not my favorite.
- We change checkpointing mode with a warning. Not my favorite.
- We disable/ignore UC (current way) with a warning (needs to be added).
- We could have a value `UC if exactly once` and make
`checkpointCfg.isUnalignedCheckpointsEnabled()` more intelligent. Would also be
plausible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
