zentol commented on a change in pull request #12682:
URL: https://github.com/apache/flink/pull/12682#discussion_r441461754
##########
File path:
flink-connectors/flink-sql-connector-hive-1.2.2/src/main/resources/META-INF/NOTICE
##########
@@ -8,6 +8,41 @@ This project bundles the following dependencies under the
Apache Software Licens
- org.apache.hive:hive-exec:1.2.2
- org.apache.hive:hive-metastore:1.2.2
+- org.apache.hive:hive-common:1.2.2
+- org.apache.hive:hive-serde:1.2.2
+- org.apache.hive.shims:hive-shims-0.20S:1.2.2
Review comment:
The hive-exec pom includes a very explicit shade-plugin include
configuration;
```
<!-- order is meant to be the same as the ant build -->
<include>org.apache.hive:hive-common</include>
<include>org.apache.hive:hive-exec</include>
<include>org.apache.hive:hive-serde</include>
<include>com.esotericsoftware.kryo:kryo</include>
<include>com.twitter:parquet-hadoop-bundle</include>
<include>org.apache.thrift:libthrift</include>
<include>commons-lang:commons-lang</include>
<include>org.apache.commons:commons-lang3</include>
<include>org.jodd:jodd-core</include>
<include>org.json:json</include>
<include>org.apache.avro:avro</include>
<include>org.apache.avro:avro-mapred</include>
<include>org.apache.hive.shims:hive-shims-0.20S</include>
<include>org.apache.hive.shims:hive-shims-0.23</include>
<include>org.apache.hive.shims:hive-shims-0.23</include>
<include>org.apache.hive.shims:hive-shims-common</include>
<include>com.googlecode.javaewah:JavaEWAH</include>
<include>javolution:javolution</include>
<include>com.google.protobuf:protobuf-java</include>
<include>org.iq80.snappy:snappy</include>
<include>org.codehaus.jackson:jackson-core-asl</include>
<include>org.codehaus.jackson:jackson-mapper-asl</include>
<include>com.google.guava:guava</include>
<include>net.sf.opencsv:opencsv</include>
<include>org.apache.hive:spark-client</include>
<include>joda-time:joda-time</include>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
