rmetzger commented on a change in pull request #12682:
URL: https://github.com/apache/flink/pull/12682#discussion_r441396842
##########
File path:
flink-connectors/flink-sql-connector-hive-1.2.2/src/main/resources/META-INF/NOTICE
##########
@@ -8,6 +8,41 @@ This project bundles the following dependencies under the
Apache Software Licens
- org.apache.hive:hive-exec:1.2.2
- org.apache.hive:hive-metastore:1.2.2
+- org.apache.hive:hive-common:1.2.2
+- org.apache.hive:hive-serde:1.2.2
+- org.apache.hive.shims:hive-shims-0.20S:1.2.2
Review comment:
I also don't know what's the best way forward. The problem is that the
Hive project is not providing a proper `NOTICE` file that we could use.
We could do something crazy and build hive 1.2.2 ourselves, and take the
output of their maven-shade-plugin run in the "hive/ql" (=`hive-exec`) run to
get all the included dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
