Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1544#issuecomment-175119125
@ChengXiangLi, actually I proposed to make all methods other than
`translateToPlan()` private methods. If the Flink RelNodes directly return the
DataSet program, we do not need to call for instance `getLeftJoinKey()` from
outside the the `FlinkDataSetJoin` but only internally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
