tillrohrmann commented on a change in pull request #11963:
URL: https://github.com/apache/flink/pull/11963#discussion_r420209933



##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -1005,58 +1001,6 @@ private void submitNoOpInvokableTask(
                tmGateway.submitTask(tdd, jobMasterGateway.getFencingToken(), 
timeout).join();
        }
 
-       /**
-        * This tests makes sure that duplicate JobMaster gained leadership 
messages are filtered out
-        * by the TaskExecutor. See FLINK-7526.
-        */
-       @Test
-       public void testFilterOutDuplicateJobMasterRegistrations() throws 
Exception {

Review comment:
       The reason I removed this test case is that the API of the `JobTable` no 
longer allows to create two `JobManagerConnections`. Hence the previous 
behaviour is now tested via 
`DefaultJobTableTest#getOrCreateJob_RegisteredJob_WillReturnRegisteredJob` and 
`#connectJob_Connected_Fails`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to