zentol commented on a change in pull request #11963:
URL: https://github.com/apache/flink/pull/11963#discussion_r419366696
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
##########
@@ -1005,58 +1001,6 @@ private void submitNoOpInvokableTask(
tmGateway.submitTask(tdd, jobMasterGateway.getFencingToken(),
timeout).join();
}
- /**
- * This tests makes sure that duplicate JobMaster gained leadership
messages are filtered out
- * by the TaskExecutor. See FLINK-7526.
- */
- @Test
- public void testFilterOutDuplicateJobMasterRegistrations() throws
Exception {
Review comment:
where is this now tested?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1794,9 +1816,12 @@ public void jobManagerLostLeadership(final JobID jobId,
final JobMasterId jobMas
log.info("JobManager for job {} with leader id {} lost
leadership.", jobId, jobMasterId);
runAsync(() ->
Review comment:
Shouldn't we only run `disconnectJobManagerConnection` asynchronous?
Just so we don't schedule something if no connection is present.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
