KarmaGYZ commented on a change in pull request #11854: URL: https://github.com/apache/flink/pull/11854#discussion_r417782697
########## File path: flink-yarn/src/main/java/org/apache/flink/yarn/ResourceInformationReflector.java ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.yarn; + +import org.apache.hadoop.yarn.api.records.Resource; + +import java.lang.reflect.Method; +import java.util.HashMap; +import java.util.Map; + +/** + * Looks up the methods related to org.apache.hadoop.yarn.api.records.Resource#setResourceInformation. + * Only supported in Hadoop 3.1+ or 2.10+. + */ +public class ResourceInformationReflector { + + static final ResourceInformationReflector INSTANCE = new ResourceInformationReflector(); + + /** Class used to set the extended resource. */ + private static final String RESOURCE_INFO_CLASS = "org.apache.hadoop.yarn.api.records.ResourceInformation"; + + private Class<?> resourceInfoClass; + private Method setResourceInfoMethod; + private Method getResourceValueMethod; + private Method getInfoNameMethod; + private Method getInfoValueMethod; + private Method resourceInfoNewInstance; + private boolean isYarnResourceTypesAvailable; Review comment: Not sure if it is worth to do that. IMO, it would hurt the readability. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
