KarmaGYZ commented on a change in pull request #11854:
URL: https://github.com/apache/flink/pull/11854#discussion_r415807586
##########
File path:
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/api/runtime/SavepointEnvironment.java
##########
@@ -198,6 +199,11 @@ public GlobalAggregateManager getGlobalAggregateManager() {
throw new UnsupportedOperationException(ERROR_MSG);
}
+ @Override
+ public Map<String, ExternalResourceDriver> getExternalResourceDrivers()
{
+ return Collections.emptyMap();
+ }
Review comment:
After an offline talk with @sjwiesman , I believe it probably makes
sense to return emptyMap here.
The root reason of the failure of the `ITCase` is that in
`BoundedOneInputStreamTaskRunner.mapPartition` we start a new
`BoundedStreamTask` with `SavepointEnvironment`. We have to do this is because
there is no way of accessing the actual execution environment from within the
dataset API. Eventually, when there is a bounded datastream api, all of this
will go away. So, at the moment, I think it would be ok to return
`Collections.emptyMap()`. @sjwiesman Please correct me if I don't express it
correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
