tillrohrmann commented on a change in pull request #11323:
URL: https://github.com/apache/flink/pull/11323#discussion_r414575394
##########
File path:
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesResourceManagerTest.java
##########
@@ -634,4 +683,15 @@ private FlinkKubeClient
createTestingFlinkKubeClientAllocatingPodsAfter(
}
};
}
+
+ private FlinkKubeClient
createTestingFlinkKubeClientCompleteCreateTaskManagerPodFutureOnTriggered(
+ CompletableFuture<Void> trigger) {
+ ExecutorService kubeClientExecutorService =
Executors.newDirectExecutorService();
+ return new Fabric8FlinkKubeClient(flinkConfig, kubeClient, ()
-> kubeClientExecutorService) {
+ @Override
+ public CompletableFuture<Void>
createTaskManagerPod(KubernetesPod kubernetesPod) {
+ return
super.createTaskManagerPod(kubernetesPod).runAfterBoth(trigger, () -> {});
Review comment:
Nice :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
