tillrohrmann commented on a change in pull request #11323:
URL: https://github.com/apache/flink/pull/11323#discussion_r413770905
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManager.java
##########
@@ -311,7 +322,9 @@ protected double getCpuCores(Configuration configuration) {
return
TaskExecutorProcessUtils.getCpuCoresWithFallbackConfigOption(configuration,
KubernetesConfigOptions.TASK_MANAGER_CPU);
}
- private void internalStopPod(String podName) {
+ private Optional<WorkerResourceSpec> internalStopPod(String podName) {
Review comment:
I don't mean to directly test this method but the behaviour in case of
pod terminations/failures. For example, I think at the moment we treat the
failure of a recovered and a started pod differently (given the state when I
reviewed this PR). In the former case we won't do anything and in the latter
case we will try to restart it. I'm not sure whether this needs to be the case.
See https://github.com/apache/flink/pull/11323#discussion_r413767396. I think
we currently don't have enough test coverage for these cases to ensure a
consistent behaviour. Without this PR, restarting recovered pods should have
worked if I'm not mistaken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
