zhuzhurk commented on a change in pull request #11829:
URL: https://github.com/apache/flink/pull/11829#discussion_r412621866
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/utils/ExecutorUtils.java
##########
@@ -85,19 +83,14 @@ public static void setBatchProperties(StreamGraph
streamGraph, TableConfig table
if (streamGraph.getCheckpointConfig().isCheckpointingEnabled())
{
throw new IllegalArgumentException("Checkpoint is not
supported for batch jobs.");
}
- if (ExecutorUtils.isShuffleModeAllBatch(tableConfig)) {
-
streamGraph.setGlobalDataExchangeMode(GlobalDataExchangeMode.ALL_EDGES_BLOCKING);
- }
+
streamGraph.setGlobalDataExchangeMode(getGlobalDataExchangeMode(tableConfig));
}
private static boolean isShuffleModeAllBatch(TableConfig tableConfig) {
Review comment:
Ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
