[GitHub] [flink] JingsongLi commented on a change in pull request #11829: [FLINK-17021][table-planner-blink] Blink batch planner set GlobalDataExchangeMode

[GitBox]

JingsongLi commented on a change in pull request #11829:
URL: https://github.com/apache/flink/pull/11829#discussion_r412605806



##########
File path: 
flink-end-to-end-tests/flink-tpcds-test/src/main/java/org/apache/flink/table/tpcds/TpcdsTestProgram.java
##########
@@ -123,8 +123,9 @@ private static TableEnvironment prepareTableEnv(String 
sourceTablePath, Boolean
                TableEnvironment tEnv = 
TableEnvironment.create(environmentSettings);
 
                //config Optimizer parameters
-               tEnv.getConfig().getConfiguration()
-                               
.setString(ExecutionConfigOptions.TABLE_EXEC_SHUFFLE_MODE, 
ShuffleMode.BATCH.toString());
+               tEnv.getConfig().getConfiguration().setString(

Review comment:
       Consider default value is `ALL_EDGES_BLOCKING`, we can remove this code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org