dawidwys commented on a change in pull request #11290: [FLINK-16379][table] 
Introduce fromValues in TableEnvironment
URL: https://github.com/apache/flink/pull/11290#discussion_r410132783
 
 

 ##########
 File path: 
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java
 ##########
 @@ -89,6 +92,235 @@ static TableEnvironment create(EnvironmentSettings 
settings) {
                return TableEnvironmentImpl.create(settings);
        }
 
+       /**
+        * Creates a Table from given values.
+        *
+        * <p>Examples:
+        *
+        * <p>You can use a {@code row(...)} expression to create a composite 
rows:
 
 Review comment:
   The reason why I didn't link to a `row` is that it will be a different 
method depending which API users use.
   It's either `org.apache.flink.table.api.Expressions#row` or 
`org.apache.flink.table.api.ImplicitExpressionConversions#row`
   
   The `TableEnvironment` is shared between java and scala. I don't have a 
strong opinion on this though. If you think it's better to link to the Java 
method I can do it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to