dawidwys commented on a change in pull request #11290: [FLINK-16379][table]
Introduce fromValues in TableEnvironment
URL: https://github.com/apache/flink/pull/11290#discussion_r410069970
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/expressions/ValueLiteralExpression.java
##########
@@ -70,7 +70,7 @@
private final DataType dataType;
public ValueLiteralExpression(Object value) {
- this(value, deriveDataTypeFromValue(value));
+ this(value, deriveDataTypeFromValue(value).notNull());
Review comment:
Why not? The `deriveDataTypeFromValue` derives a type based on a
boxed(always) type, which always produces nullable type.
In other words `deriveDataTypeFromValue` will never produce a `notNull` type
which is wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
