zentol commented on a change in pull request #11764: [FLINK-17023][scripts] Fix
format checking of extractExecutionParams in config.sh
URL: https://github.com/apache/flink/pull/11764#discussion_r410034958
##########
File path: flink-dist/src/main/flink-bin/bin/config.sh
##########
@@ -644,9 +644,17 @@ extractExecutionParams() {
local execution_config=$1
local EXECUTION_PREFIX="BASH_JAVA_UTILS_EXEC_RESULT:"
- if ! [[ $execution_config =~ ^${EXECUTION_PREFIX}.* ]]; then
+ local line_count=`echo "$execution_config" | grep "" -c`
Review comment:
`taskmanager.sh` uses a different way of counting lines: `num_lines=$(echo
"${java_utils_output}" | wc -l)`
I'd prefer if we stick to 1 way of doing it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
