TsReaper commented on issue #11764: [FLINK-17023][scripts] Fix format checking 
of extractExecutionParams in config.sh
URL: https://github.com/apache/flink/pull/11764#issuecomment-614644705
 
 
   > Not sure I understand the problem, `extractExecutionParams` is only ever 
called for a single line.
   > 
   > ```
   > jvm_params=$(extractExecutionParams "$(echo "$params_output" | head -n 1)")
   > dynamic_configs=$(extractExecutionParams "$(echo "$params_output" | tail 
-n 1)")
   > ```
   
   OK I didn't notice that `extractExecutionParams` is only called for a single 
line. So shall we add this restriction to `extractExecutionParams` and change 
its error message? I'm submitting this PR because I feed multiple lines to 
`extractExecutionParams` in my code and get the error message saying that the 
format of my last line is incorrect, which is not the case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to