dianfu commented on a change in pull request #11749:
[FLINK-16669][python][table] Support Python UDF in SQL function DDL.
URL: https://github.com/apache/flink/pull/11749#discussion_r409972882
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/functions/FunctionDefinitionUtil.java
##########
@@ -18,13 +18,34 @@
package org.apache.flink.table.functions;
+import org.apache.flink.configuration.ReadableConfig;
+import org.apache.flink.table.catalog.FunctionLanguage;
+
+import java.lang.reflect.InvocationTargetException;
+
/**
* A util to instantiate {@link FunctionDefinition} in the default way.
*/
public class FunctionDefinitionUtil {
public static FunctionDefinition createFunctionDefinition(String name,
String className) {
- // Currently only handles Java class-based functions
+ return createJavaFunctionDefinition(name, className);
+ }
+
+ public static FunctionDefinition createFunctionDefinition(
+ String name,
+ String className,
+ FunctionLanguage functionLanguage,
+ ReadableConfig config) {
+ switch (functionLanguage) {
Review comment:
It complains in my IDE that `switch has too few case labels`. Could you
resolve this warning?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
