dianfu commented on a change in pull request #11749:
[FLINK-16669][python][table] Support Python UDF in SQL function DDL.
URL: https://github.com/apache/flink/pull/11749#discussion_r409973891
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/operations/SqlToOperationConverter.java
##########
@@ -259,10 +259,17 @@ private Operation
convertCreateFunction(SqlCreateFunction sqlCreateFunction) {
return new CreateTempSystemFunctionOperation(
unresolvedIdentifier.getObjectName(),
sqlCreateFunction.getFunctionClassName().getValueAs(String.class),
- sqlCreateFunction.isIfNotExists()
+ sqlCreateFunction.isIfNotExists(),
+
parseLanguage(sqlCreateFunction.getFunctionLanguage())
);
} else {
FunctionLanguage language =
parseLanguage(sqlCreateFunction.getFunctionLanguage());
+ if (language == FunctionLanguage.PYTHON &&
!sqlCreateFunction.isTemporary()) {
+ throw new ValidationException(String.format(
Review comment:
fix the warning here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
