pnowojski commented on a change in pull request #11687:
[FLINK-16536][network][checkpointing] Implement InputChannel state recovery for
unaligned checkpoint
URL: https://github.com/apache/flink/pull/11687#discussion_r408338769
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -243,7 +249,23 @@ void requestPartitions() throws IOException,
InterruptedException {
}
for (InputChannel inputChannel :
inputChannels.values()) {
- inputChannel.requestSubpartition();
+ executor.submit(() -> {
+ try {
+
inputChannel.initializeState(reader);
+ } catch (Throwable t) {
+
inputChannel.setError(t);
+ }
+ });
Review comment:
I would move the for loop inside the executor, to avoid race conditions and
not depend on `executor` being single threaded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
