pnowojski commented on a change in pull request #11687: 
[FLINK-16536][network][checkpointing] Implement InputChannel state recovery for 
unaligned checkpoint
URL: https://github.com/apache/flink/pull/11687#discussion_r406231112
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
 ##########
 @@ -95,7 +95,7 @@ public LocalInputChannel(
        // 
------------------------------------------------------------------------
 
        @Override
-       protected void requestSubpartition(int subpartitionIndex) throws 
IOException, InterruptedException {
+       protected void requestSubpartition() throws IOException, 
InterruptedException {
 
 Review comment:
   Are those changes about dropping `int subpartitionIndex` (significant part 
of this commit) related to the main purpose of the PR? Shouldn't they be a 
separate commit?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to