tillrohrmann commented on a change in pull request #11699: [FLINK-17082][sql] Remove mocking in SQL client URL: https://github.com/apache/flink/pull/11699#discussion_r408192029
########## File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/TestingExecutor.java ########## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.client.cli; + +import org.apache.flink.api.java.tuple.Tuple2; +import org.apache.flink.table.api.TableSchema; +import org.apache.flink.table.client.config.entries.ViewEntry; +import org.apache.flink.table.client.gateway.Executor; +import org.apache.flink.table.client.gateway.ProgramTargetDescriptor; +import org.apache.flink.table.client.gateway.ResultDescriptor; +import org.apache.flink.table.client.gateway.SessionContext; +import org.apache.flink.table.client.gateway.SqlExecutionException; +import org.apache.flink.table.client.gateway.TypedResult; +import org.apache.flink.types.Row; +import org.apache.flink.util.function.BiConsumerWithException; +import org.apache.flink.util.function.SupplierWithException; + +import java.util.List; +import java.util.Map; + +/** + * A customizable {@link Executor} for testing purposes. + */ +class TestingExecutor implements Executor { + + int numCancelCalls = 0; Review comment: I think I would not expose the fields directly. Instead I would propose to introduce simple getters. The benefit would be that one could change the underlying implementation if need arises and adding the getters should not be much of an overhead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
