tillrohrmann commented on a change in pull request #11699: [FLINK-17082][sql] Remove mocking in SQL client URL: https://github.com/apache/flink/pull/11699#discussion_r408190467
########## File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/TestingExecutor.java ########## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.client.cli; + +import org.apache.flink.api.java.tuple.Tuple2; +import org.apache.flink.table.api.TableSchema; +import org.apache.flink.table.client.config.entries.ViewEntry; +import org.apache.flink.table.client.gateway.Executor; +import org.apache.flink.table.client.gateway.ProgramTargetDescriptor; +import org.apache.flink.table.client.gateway.ResultDescriptor; +import org.apache.flink.table.client.gateway.SessionContext; +import org.apache.flink.table.client.gateway.SqlExecutionException; +import org.apache.flink.table.client.gateway.TypedResult; +import org.apache.flink.types.Row; +import org.apache.flink.util.function.BiConsumerWithException; +import org.apache.flink.util.function.SupplierWithException; + +import java.util.List; +import java.util.Map; + +/** + * A customizable {@link Executor} for testing purposes. + */ +class TestingExecutor implements Executor { + + int numCancelCalls = 0; + + int numRetrieveResultChancesCalls = 0; + private final List<SupplierWithException<TypedResult<List<Tuple2<Boolean, Row>>>, SqlExecutionException>> resultChanges; + + int numSnapshotResultCalls = 0; + private final List<SupplierWithException<TypedResult<Integer>, SqlExecutionException>> snapshotResults; + + int numRetrieveResultPageCalls = 0; + private final List<SupplierWithException<List<Row>, SqlExecutionException>> resultPages; + + int numUseCatalogCalls = 0; + private final BiConsumerWithException<String, String, SqlExecutionException> useCatalogConsumer; + + int numUseDatabaseCalls = 0; + private BiConsumerWithException<String, String, SqlExecutionException> useDatabaseConsumer; + + TestingExecutor( + List<SupplierWithException<TypedResult<List<Tuple2<Boolean, Row>>>, SqlExecutionException>> resultChanges, + List<SupplierWithException<TypedResult<Integer>, SqlExecutionException>> snapshotResults, + List<SupplierWithException<List<Row>, SqlExecutionException>> resultPages, + BiConsumerWithException<String, String, SqlExecutionException> useCatalogConsumer, + BiConsumerWithException<String, String, SqlExecutionException> useDatabaseConsumer) { + this.resultChanges = resultChanges; + this.snapshotResults = snapshotResults; + this.resultPages = resultPages; + this.useCatalogConsumer = useCatalogConsumer; + this.useDatabaseConsumer = useDatabaseConsumer; + } + + @Override + public void cancelQuery(String sessionId, String resultId) throws SqlExecutionException { + numCancelCalls++; + } + + @Override + public TypedResult<List<Tuple2<Boolean, Row>>> retrieveResultChanges(String sessionId, String resultId) throws SqlExecutionException { + return resultChanges.get(Math.min(numRetrieveResultChancesCalls++, resultChanges.size() - 1)).get(); + } + + @Override + public List<Row> retrieveResultPage(String resultId, int page) throws SqlExecutionException { + return resultPages.get(Math.min(numRetrieveResultPageCalls++, resultPages.size() - 1)).get(); + } + + @Override + public TypedResult<Integer> snapshotResult(String sessionId, String resultId, int pageSize) throws SqlExecutionException { + return snapshotResults.get(Math.min(numSnapshotResultCalls++, snapshotResults.size() - 1)).get(); + } + + @Override + public void useCatalog(String sessionId, String catalogName) throws SqlExecutionException { + numUseCatalogCalls++; + useCatalogConsumer.accept(sessionId, catalogName); + } + + @Override + public void useDatabase(String sessionId, String databaseName) throws SqlExecutionException { + numUseDatabaseCalls++; + useDatabaseConsumer.accept(sessionId, databaseName); + } + + @Override + public void start() throws SqlExecutionException { + } + + @Override + public String openSession(SessionContext session) throws SqlExecutionException { + return null; Review comment: Is this a valid return value? Maybe it is better to throw an `UnsupportedOperationException` instead of returning `null`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
