twalthr commented on a change in pull request #11694:
[FLINK-17064][table-planner] Improve literals conversion in ExpressionConverter
URL: https://github.com/apache/flink/pull/11694#discussion_r408071169
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/calcite/FlinkTypeFactory.scala
##########
@@ -123,6 +123,9 @@ class FlinkTypeFactory(typeSystem: RelDataTypeSystem)
extends JavaTypeFactoryImp
true,
getTypeSystem)
+ case LogicalTypeRoot.SYMBOL =>
+ createSqlType(SqlTypeName.SYMBOL)
Review comment:
Either we need our own `SymbolRelDataType` or we need to adapt our logical
type. This can be a follow up. I just would like to add a TODO or JIRA issue to
not forget about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
