dawidwys commented on a change in pull request #11694:
[FLINK-17064][table-planner] Improve literals conversion in ExpressionConverter
URL: https://github.com/apache/flink/pull/11694#discussion_r408069699
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/calcite/FlinkTypeFactory.scala
##########
@@ -123,6 +123,9 @@ class FlinkTypeFactory(typeSystem: RelDataTypeSystem)
extends JavaTypeFactoryImp
true,
getTypeSystem)
+ case LogicalTypeRoot.SYMBOL =>
+ createSqlType(SqlTypeName.SYMBOL)
Review comment:
Calcite's `SYMBOL` type does not store the class/kind of the symbol in the
type itself. It is actually a pseudo type if I understand it correctly. This
type can be used only for literals and therefore the class/kind is already part
of the stored value.
So there is no reason to store it separately imo. Or do you think we need
our own `SymbolRelDataType`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
