AHeise commented on a change in pull request #11507: [FLINK-16587] Add basic
CheckpointBarrierHandler for unaligned checkpoint
URL: https://github.com/apache/flink/pull/11507#discussion_r408062385
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -206,6 +214,25 @@ void retriggerSubpartitionRequest(int subpartitionIndex)
throws IOException {
return Optional.of(new BufferAndAvailability(next,
moreAvailable, getSenderBacklog()));
}
+ @Override
+ public List<Buffer> requestInflightBuffers(long checkpointId) throws
IOException {
+ synchronized (receivedBuffers) {
+ checkState(checkpointId > lastRequestedCheckpointId,
"Need to request the next checkpointId");
+
+ final List<Buffer> inflightBuffers = new
ArrayList<>(receivedBuffers.size());
+ for (Buffer buffer : receivedBuffers) {
+ if (!buffer.isBuffer() &&
parseCheckpointBarrierOrNull(buffer) != null) {
+ break;
Review comment:
Good point, probably more relevant when we have concurrent checkpoints. But
I added it anyways (it should be the same `checkpointId` currently, I made it
safer with `>= checkpointId`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
